Unconditionally use ts_rs and remove 'ts-bindings' feature#7245
Open
Unconditionally use ts_rs and remove 'ts-bindings' feature#7245
Conversation
The upcoming ts-executor-pool crate will need to access the generated bindings (to show to the LLM when typescript tool calls are enabled).
AntoineToussaint
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upcoming ts-executor-pool crate will need to access the generated bindings (to show to the LLM when typescript tool calls are enabled).
Note
Medium Risk
Medium risk because it touches Cargo feature/dependency wiring across many crates and changes TypeScript export attributes, which could break builds or generated bindings if any crate relied on the old
ts-bindingsgating.Overview
Makes TypeScript bindings generation unconditional by removing the
ts-bindingsfeature flag across the workspace and switching all#[cfg_attr(feature = "ts-bindings", ...)]usages to always-onts_rsderives/#[ts(...)]attributes.Updates crate dependencies to include
ts-rs/tensorzero-ts-typesnon-optionally, stripsts-bindingsfeature definitions from multipleCargo.tomls, and adjusts thetsbuildcargo alias to no longer pass--features ts-bindings.Reviewed by Cursor Bugbot for commit 85bda0d. Bugbot is set up for automated code reviews on this repo. Configure here.