Switch some dependencies to aws-lc-sys from ring#7226
Open
Conversation
There are still some dependencies that we can't adjust yet (e.g. `object_store`). Once those are updated upstream, we should ban `ring` (which not does support post-quantum cryptography)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 62b559e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still some dependencies that we can't adjust yet (e.g.
object_store). Once those are updated upstream, we should banring(which not does support post-quantum cryptography)Note
Medium Risk
Swaps TLS/crypto providers from
ringtoaws-lc-rs(including certificate generation and SQLx TLS), which can impact handshake compatibility and platform-specific behavior despite limited code churn.Overview
Moves parts of the Rust workspace off
ringand onto theaws-lc-rscrypto backend.Updates workspace TLS dependencies by switching
sqlxtotls-rustls-aws-lc-rs, configuringprovider-proxyto usercgenwithaws_lc_rsand the workspacerustls, and installing therustls::crypto::aws_lc_rsdefault provider at runtime.Cargo.lockis updated accordingly (notablyrcgen/x509-parsernow depend onaws-lc-rs, plus minor patch bumps liketokio,semver,fastrand, andtoml_edit).Reviewed by Cursor Bugbot for commit 62b559e. Bugbot is set up for automated code reviews on this repo. Configure here.