PARAFAC2: hybridize SVD init for high rank and add warning/tests#617
Open
MiklosKralik wants to merge 1 commit intotensorly:mainfrom
Open
PARAFAC2: hybridize SVD init for high rank and add warning/tests#617MiklosKralik wants to merge 1 commit intotensorly:mainfrom
MiklosKralik wants to merge 1 commit intotensorly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run into a use-case of PARAFAC2 where I would like to initialize the decomposition with svd features (for a sensible initialization) but would like to allow for the decomposition to fit a higher rank than the dimension of the data. I've added some logic to concatenate svd initialized rankd with randomly initialized ranks for this use case.
I've added a UserWarning as this use case is rare and the user should be intentional when specifying a high rank. I've also added a unittest of rebroducibility for this init mode.