Remove all_opensource_files#16491
Conversation
|
I have found a few additional internal checks that depend on this, so we are not ready to merge this PR yet. |
|
Looks like we will still need to export some of the files or change their visibility so other targets can access them. How should we go about this? @gunan any suggestion? |
|
I think we need some filegroup rules, and new data dependencies on these filegroup rules. Those fixes should be a part of this, as they will be "thinner" replacements to the all_files rules these tests are already depending on. |
|
@Androbin do you mind adding this suggested fix: |
|
Good catch! |
|
Last build failed because of |
|
Looks like there are a few more: |
|
Okay, that made |
|
Thanks @Androbin! Let's see how the builds go. |
|
We had some infra issue earlier. It should be fine now. |
|
Hi @Androbin sorry for the delay, I was thinking of bringing this PR in independently and was waiting for the sync to resolve merge conflicts. Let me give it another shot. |
|
@Androbin I managed to create a pending internal change with your PR, and unfortunately found another internal dependency on all_files. Will let you know once we figure out how we can remove it. Thanks. |
|
@Androbin quick update: the internal dependency issue has been fixed. I'm working on submitting this change internally following this process. |
|
Nagging Assignee @gunan: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly. |
Fixes #15758
@gunan /cc
@yifeif /cc