Skip to content

Remove all_opensource_files#16491

Closed
Androbin wants to merge 4 commits into
tensorflow:masterfrom
Androbin:makefile
Closed

Remove all_opensource_files#16491
Androbin wants to merge 4 commits into
tensorflow:masterfrom
Androbin:makefile

Conversation

@Androbin
Copy link
Copy Markdown
Contributor

Fixes #15758
@gunan /cc
@yifeif /cc

@andrewharp andrewharp requested a review from gunan January 29, 2018 22:22
@andrewharp andrewharp added kokoro:run awaiting review Pull request awaiting review labels Jan 29, 2018
@gunan
Copy link
Copy Markdown
Contributor

gunan commented Jan 29, 2018

I have found a few additional internal checks that depend on this, so we are not ready to merge this PR yet.
We need to discuss how we can move those checks to not use bazel.

@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Feb 6, 2018

Looks like we will still need to export some of the files or change their visibility so other targets can access them. How should we go about this? @gunan any suggestion?

@gunan
Copy link
Copy Markdown
Contributor

gunan commented Feb 7, 2018

I think we need some filegroup rules, and new data dependencies on these filegroup rules. Those fixes should be a part of this, as they will be "thinner" replacements to the all_files rules these tests are already depending on.
Could you go through the broken tests and triage the build failures?

@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Feb 7, 2018

@Androbin do you mind adding this suggested fix:
/tmpfs/src/github/tensorflow/tensorflow/core/ops/compat/BUILD:33:1: no such target '//tensorflow/core:ops/ops.pbtxt': target 'ops/ops.pbtxt' not declared in package 'tensorflow/core'; however, a source file of this name exists. (Perhaps add 'exports_files(["ops/ops.pbtxt"])' to tensorflow/core/BUILD?) defined by /tmpfs/src/github/tensorflow/tensorflow/core/BUILD and referenced by '//tensorflow/core/ops/compat:backwards_compatibility_test'

@Androbin
Copy link
Copy Markdown
Contributor Author

Androbin commented Feb 7, 2018

Good catch!

@yifeif yifeif added the kokoro:force-run Tests on submitted change label Feb 7, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 7, 2018
@Androbin
Copy link
Copy Markdown
Contributor Author

Androbin commented Feb 21, 2018

Last build failed because of image_retraining.
Rebased on last successful build and resolved merge conflicts.

@gunan gunan added the kokoro:force-run Tests on submitted change label Feb 21, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 21, 2018
@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Feb 21, 2018

Looks like there are a few more:
ERROR: /tmpfs/src/github/tensorflow/tensorflow/examples/image_retraining/BUILD:28:1: no such target '//tensorflow/examples/label_image:data/grace_hopper.jpg': target 'data/grace_hopper.jpg' not declared in package 'tensorflow/examples/label_image'; however, a source file of this name exists. (Perhaps add 'exports_files(["data/grace_hopper.jpg"])' to tensorflow/examples/label_image/BUILD?) defined by /tmpfs/src/github/tensorflow/tensorflow/examples/label_image/BUILD and referenced by '//tensorflow/examples/image_retraining:retrain_test'

@Androbin
Copy link
Copy Markdown
Contributor Author

Okay, that made bazel nobuild pass locally.

@yifeif yifeif added the kokoro:force-run Tests on submitted change label Feb 21, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 21, 2018
@Androbin
Copy link
Copy Markdown
Contributor Author

Androbin commented Mar 1, 2018

Last build succeeded (256848f).
Had to resolve minor merge conflict (620348f).

@yifeif yifeif added the kokoro:force-run Tests on submitted change label Mar 1, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 1, 2018
@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Mar 1, 2018

Thanks @Androbin! Let's see how the builds go.

@yifeif yifeif added the kokoro:force-run Tests on submitted change label Mar 1, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 1, 2018
@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Mar 1, 2018

We had some infra issue earlier. It should be fine now.

@yifeif yifeif added the kokoro:force-run Tests on submitted change label Mar 1, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 1, 2018
@Androbin
Copy link
Copy Markdown
Contributor Author

Androbin commented Mar 3, 2018

Last build successful (99f5d4e)
Had to resolve minor merge conflict (f6bda40)

@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Mar 6, 2018

Hi @Androbin sorry for the delay, I was thinking of bringing this PR in independently and was waiting for the sync to resolve merge conflicts. Let me give it another shot.

@yifeif yifeif added the kokoro:force-run Tests on submitted change label Mar 6, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 6, 2018
@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Mar 6, 2018

@Androbin I managed to create a pending internal change with your PR, and unfortunately found another internal dependency on all_files. Will let you know once we figure out how we can remove it. Thanks.

@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Mar 14, 2018

@Androbin quick update: the internal dependency issue has been fixed. I'm working on submitting this change internally following this process.

@tensorflowbutler
Copy link
Copy Markdown
Member

Nagging Assignee @gunan: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@yifeif
Copy link
Copy Markdown
Contributor

yifeif commented Mar 30, 2018

bb582f1 has been submitted. I'm going to close this PR. Thanks @Androbin!

@yifeif yifeif closed this Mar 30, 2018
@Androbin Androbin deleted the makefile branch March 30, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review Pull request awaiting review cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants