Skip to content

Turn check_futures_test into a sanity check#15671

Merged
martinwicke merged 1 commit into
tensorflow:masterfrom
Androbin:futures
Jan 23, 2018
Merged

Turn check_futures_test into a sanity check#15671
martinwicke merged 1 commit into
tensorflow:masterfrom
Androbin:futures

Conversation

@Androbin
Copy link
Copy Markdown
Contributor

@Androbin Androbin commented Dec 27, 2017 •
edited
Loading

See #15368 (comment) for reference.
@gunan @martinwicke /cc

@tensorflow-jenkins
Copy link
Copy Markdown
Collaborator

tensorflow-jenkins commented Dec 27, 2017

Can one of the admins verify this patch?

@drpngx drpngx requested review from gunan and martinwicke December 27, 2017 23:48
@drpngx drpngx added the awaiting review Pull request awaiting review label Dec 27, 2017
@drpngx
Copy link
Copy Markdown
Contributor

drpngx commented Dec 27, 2017

Could you check your script?

=== Sanity check step 3 of 11: do_check_futures_test (Check that python files have certain __future__ imports) ===

Traceback (most recent call last):
  File "check_futures_test.py", line 107, in <module>
    main()
  File "check_futures_test.py", line 90, in main
    BASE_DIR)
AssertionError: BASE_DIR = '../..' doesn't end with tensorflow

@Androbin
Copy link
Copy Markdown
Contributor Author

Androbin commented Dec 28, 2017 •
edited
Loading

Interesting, os.path.normpath may fail depending on the working directory.
Substituting with os.path.abspath should do the trick.

@drpngx
Copy link
Copy Markdown
Contributor

drpngx commented Dec 28, 2017

Jenkins, test this please.

@drpngx
Copy link
Copy Markdown
Contributor

drpngx commented Dec 29, 2017

Yes, the build is stuck today. We'll have to wait a bit.

@Androbin Androbin mentioned this pull request Dec 31, 2017
Closed
5 tasks
@drpngx
Copy link
Copy Markdown
Contributor

drpngx commented Jan 1, 2018

Jenkins, test this please.

@drpngx
Copy link
Copy Markdown
Contributor

drpngx commented Jan 1, 2018

Oh, I think it's good. Ubuntu CC moved to kokoro, I think, so the build is good. Waiting for review.

@martinwicke
Copy link
Copy Markdown
Member

martinwicke commented Jan 22, 2018

Looks good to me. @gunan unless you object violently and soon.

@martinwicke martinwicke added awaiting testing (then merge) and removed awaiting review Pull request awaiting review labels Jan 22, 2018
@rmlarsen
Copy link
Copy Markdown
Contributor

rmlarsen commented Jan 22, 2018

@Androbin Please resolve conflicts.

@rmlarsen rmlarsen added the stat:awaiting response Status - Awaiting response from author label Jan 22, 2018
@rmlarsen rmlarsen self-assigned this Jan 22, 2018
@Androbin
Copy link
Copy Markdown
Contributor Author

Androbin commented Jan 23, 2018

@rmlarsen Conflicts resolved.

@rmlarsen rmlarsen added kokoro:run and removed stat:awaiting response Status - Awaiting response from author labels Jan 23, 2018
@martinwicke martinwicke merged commit 0690e19 into tensorflow:master Jan 23, 2018
@martinwicke
Copy link
Copy Markdown
Member

martinwicke commented Jan 23, 2018

Almost there! Thanks!

@Androbin Androbin deleted the futures branch January 23, 2018 19:20
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
71fcede 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
@copybara-service copybara-service Bot mentioned this pull request Aug 5, 2024
Closed
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
93836af 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
af1a282 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
caf0c9a 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
597be7e 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
4788389 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
a43173f 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
copybara-service Bot pushed a commit that referenced this pull request Aug 5, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
039e060 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
c8ce4f7107a7f308bdcb8e252aa6f406aead6fe7 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Fix build after 21311f23028acfd4bc2c3e4a3f76bad8c9e640e8

--
5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795 by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir 5ceeec1c3ccbc926fc85330cccfbfbc4a70eb795
PiperOrigin-RevId: 659426850
copybara-service Bot pushed a commit that referenced this pull request Aug 27, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
0a04feb 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
b955a9219d3602b0ac82c762f1fb93d6e2cd511d by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir b955a9219d3602b0ac82c762f1fb93d6e2cd511d
PiperOrigin-RevId: 668039209
@copybara-service copybara-service Bot mentioned this pull request Aug 27, 2024
Merged
copybara-service Bot pushed a commit that referenced this pull request Aug 27, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
4c44bb8 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
b955a9219d3602b0ac82c762f1fb93d6e2cd511d by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir b955a9219d3602b0ac82c762f1fb93d6e2cd511d
PiperOrigin-RevId: 668039209
copybara-service Bot pushed a commit that referenced this pull request Aug 27, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
7c285b3 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
b955a9219d3602b0ac82c762f1fb93d6e2cd511d by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir b955a9219d3602b0ac82c762f1fb93d6e2cd511d
PiperOrigin-RevId: 668089870
@copybara-service copybara-service Bot mentioned this pull request Aug 27, 2024
Closed
copybara-service Bot pushed a commit that referenced this pull request Aug 27, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
0670e90 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
b955a9219d3602b0ac82c762f1fb93d6e2cd511d by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15671 from ROCm:rocm_mlir b955a9219d3602b0ac82c762f1fb93d6e2cd511d
PiperOrigin-RevId: 668039209
copybara-service Bot pushed a commit that referenced this pull request Aug 27, 2024
@draganmladjenovic @tensorflower-gardener
PR #15671: [ROCM] Enable basic functionality to run MLIR fussion tests
8f701a6 
Imported from GitHub PR openxla/xla#15671

Specific tests will be fixed as we go
Copybara import of the project:

--
b955a9219d3602b0ac82c762f1fb93d6e2cd511d by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>:

[ROCM] Add basic scaffolding and enable MLIR fusion

Merging this change closes #15671

PiperOrigin-RevId: 668122232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinwicke martinwicke martinwicke approved these changes

@gunan gunan Awaiting requested review from gunan

Assignees

@rmlarsen rmlarsen

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Androbin @tensorflow-jenkins @drpngx @martinwicke @rmlarsen @googlebot @kokoro-team