Optimize HloProgram::Fingerprint#115465
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 9, 2026
Merged
Conversation
6a35a0b to
0e19263
Compare
* Maintain a tiny buffer in `HighwayHashStream` to handle character-by-character writes more efficiently. * Always use the generic form printing for fingerprinting `HloProgram`: Using custom print functions requires running the op validator, which may be expensive. Since we don't care about pretty-printing operations while calculating a fingerprint, it makes sense to always use the generic form to save the validation cost. PiperOrigin-RevId: 896803835
0e19263 to
7ae9294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize
HloProgram::FingerprintHighwayHashStreamto handle character-by-character writes more efficiently.HloProgram: Using custom print functions requires running the op validator, which may be expensive. Since we don't care about pretty-printing operations while calculating a fingerprint, it makes sense to always use the generic form to save the validation cost.