Implement commitChanges on vz-line-chart2#3571
Merged
Merged
Conversation
This is a roll forward of 46b6e61. The commit partiall rolls back 27d0023 which introduces `commitChanges` which was supposed to be invoked after setting data, visible series, or metadata. This change addresses the regression caused by 27d0023 which forgot to call the new API in all places where we use the vz-line-chart2.
wchargin
approved these changes
May 6, 2020
Contributor
wchargin
left a comment
There was a problem hiding this comment.
Out of curiosity, is there an easy git grep or similar to double-check
that we’ve gotten them all?
Contributor
Author
|
I did few passes of
and manually inspected if they had appropriate |
Contributor
|
Sounds good; thanks! |
caisq
pushed a commit
to caisq/tensorboard
that referenced
this pull request
May 19, 2020
This is a roll forward of 46b6e61. The commit partiall rolls back 27d0023 which introduces `commitChanges` which was supposed to be invoked after setting data, visible series, or metadata. This change addresses the regression caused by 27d0023 which forgot to call the new API in all places where we use the vz-line-chart2.
caisq
pushed a commit
that referenced
this pull request
May 27, 2020
This is a roll forward of 46b6e61. The commit partiall rolls back 27d0023 which introduces `commitChanges` which was supposed to be invoked after setting data, visible series, or metadata. This change addresses the regression caused by 27d0023 which forgot to call the new API in all places where we use the vz-line-chart2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a roll forward of 46b6e61 (#3552). The commit partially rolls back
27d0023 (#3524) which introduces
commitChangeswhich was supposed to beinvoked after setting data, visible series, or metadata.
This change addresses the regression caused by 27d0023 which forgot to
call the new API in all places where we use the vz-line-chart2.