This repository was archived by the owner on Jul 7, 2023. It is now read-only.
v1.5.1#577
Merged
Merged
Conversation
PiperOrigin-RevId: 185328910
Contributor
Author
|
I'm trying to see if I can simply add tests against 1.4.... |
lukaszkaiser
approved these changes
Feb 12, 2018
Contributor
Author
|
Good to go once Travis passes. |
martinpopel
reviewed
Feb 12, 2018
| hparams_fname = os.path.join(output_dir, "hparams.json") | ||
| with tf.gfile.Open(hparams_fname, "w") as f: | ||
| f.write(hparams.to_json(indent=0, sort_keys=True)) | ||
| # TODO(lukaszkaiser): use the first line once we require TF 1.5+. |
Contributor
Author
|
Yeah we’ll update that. Cloud ML Engine only supports 1.4 and we’d like to
support launching on it.
…On Mon, Feb 12, 2018 at 1:51 AM Martin Popel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tensor2tensor/bin/t2t_trainer.py
<#577 (comment)>
:
> @@ -274,7 +274,9 @@ def save_metadata(hparams):
# Save hparams as hparams.json
hparams_fname = os.path.join(output_dir, "hparams.json")
with tf.gfile.Open(hparams_fname, "w") as f:
- f.write(hparams.to_json(indent=0, sort_keys=True))
+ # TODO(lukaszkaiser): use the first line once we require TF 1.5+.
TF 1.5+ is already required in setup.py
<https://github.com/tensorflow/tensor2tensor/blob/64d1f9666e1bb5e7813013ccc48b85cab77735dd/setup.py#L48-L49>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#577 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABEGW8vyAFb1HToVfre2UEcTKVANni2Sks5tUAm2gaJpZM4SBrpm>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.