Skip to content

Pom profile changes #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karllessard merged 6 commits into from
Mar 29, 2024
Merged

Pom profile changes #525

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcf226e
Candidate fixes for profiles.
Craigacp Mar 1, 2024
c952089
Moving tensorflow-core-platform to the deploying profile.
Craigacp Mar 1, 2024
00a84dc
Make spotless happy.
Craigacp Mar 1, 2024
aa740ad
Removing extensions from tensorflow-core-platform pom.
Craigacp Mar 8, 2024
ccc7366
Merge branch 'master' into pom-fixes
Craigacp Mar 25, 2024
2579465
More pom fixes.
Craigacp Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing extensions from tensorflow-core-platform pom.
  • Loading branch information
@Craigacp
Craigacp committed Mar 8, 2024
commit aa740ad9c6d4b0757f7ec86cc866d8f711d2588e
8 changes: 4 additions & 4 deletions tensorflow-core/tensorflow-core-platform/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,25 +41,25 @@
<groupId>org.tensorflow</groupId>
<artifactId>tensorflow-core-native</artifactId>
<version>${project.version}</version>
<classifier>${javacpp.platform.linux-x86_64.extension}</classifier>
<classifier>linux-x86_64</classifier>
Copy link
Copy Markdown
Collaborator

@karllessard karllessard Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep using properties but the with an extension here (e.g. ${javacpp.platform.linux-x86_64), just so we know the values are consistent. Not strong opinion either way.

</dependency>
<dependency>
<groupId>org.tensorflow</groupId>
<artifactId>tensorflow-core-native</artifactId>
<version>${project.version}</version>
<classifier>${javacpp.platform.macosx-arm64.extension}</classifier>
<classifier>macosx-arm64</classifier>
</dependency>
<dependency>
<groupId>org.tensorflow</groupId>
<artifactId>tensorflow-core-native</artifactId>
<version>${project.version}</version>
<classifier>${javacpp.platform.macosx-x86_64.extension}</classifier>
<classifier>macosx-x86_64</classifier>
</dependency>
<dependency>
<groupId>org.tensorflow</groupId>
<artifactId>tensorflow-core-native</artifactId>
<version>${project.version}</version>
<classifier>${javacpp.platform.windows-x86_64.extension}</classifier>
<classifier>windows-x86_64</classifier>
</dependency>
</dependencies>

Expand Down