Skip to content

Upgrade to TF 2.10.1, with macosx-arm64 support#481

Merged
karllessard merged 13 commits into
tensorflow:masterfrom
karllessard:tf-upgrade-m1
Dec 28, 2022
Merged

Upgrade to TF 2.10.1, with macosx-arm64 support#481
karllessard merged 13 commits into
tensorflow:masterfrom
karllessard:tf-upgrade-m1

Conversation

@karllessard
Copy link
Copy Markdown
Collaborator

This PR does (a bit unfortunately) two different things:

  • Upgrade to TensorFlow 2.10.1
  • Enable building from sources on Apple Silicon machines (M1)

I tried to upgrade to the now released TF 2.11.0 but hit a bunch of new problems which I want to deal with later, let's get at least MacOX ARM64 build working with a still recent version of TensorFlow (2.10.1)

Addresses #394 and #252

@karllessard karllessard added the CI build Triggers a full native build on a pull request label Dec 16, 2022
Comment thread tensorflow-core/pom.xml
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread tensorflow-core/tensorflow-core-api/build.sh
@Craigacp
Copy link
Copy Markdown
Collaborator

As 2.10/2.11 get merged in we might want to think about how to expose the new model fingerprint support, and if we can generate similar fingerprints from TF-Java - https://github.com/tensorflow/community/blob/master/rfcs/20220610-saved-model-fingerprinting.md.

@karllessard
Copy link
Copy Markdown
Collaborator Author

Linux GPU was failing to build, looks like this is a known problem and I've applied a patch found here that might fix it, we'll see.

Craigacp
Craigacp previously approved these changes Dec 24, 2022
Copy link
Copy Markdown
Collaborator

@Craigacp Craigacp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming we get a clean CI build.

@karllessard
Copy link
Copy Markdown
Collaborator Author

There is an issue with the java_op_exporter in Linux that does not find the TF shared libraries now that I'm linking to it. Should be easy to fix with LD_LIBRARY_PATH, I'll test it out and push new changes

@karllessard
Copy link
Copy Markdown
Collaborator Author

Ok, works in Linux and MacOS now, but for Windows I need to merge it first so the builds can continue over 6 hours. I'll repair after if needed.

@karllessard karllessard merged commit a617fe9 into tensorflow:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI build Triggers a full native build on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants