Skip to content

Use JDK 11 by default #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karllessard merged 7 commits into from
Mar 8, 2022
+226 −51
Merged

Use JDK 11 by default #427

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
391cd92
Upgrade minimal supported JDK to 11
karllessard Feb 16, 2022
0564869
Build by default on JDK11
karllessard Feb 23, 2022
50a9a36
Fix build on JDK17 and spotless checks
karllessard Mar 3, 2022
2d194be
Use JAVA_HOME from setup-java action
karllessard Mar 3, 2022
fdfc6e0
Enforce usage of VC2019 on Windows
karllessard Mar 3, 2022
377185c
Add minimum Java version to version mapping table
karllessard Mar 8, 2022
1a2a8ce
Add minimum Java version to version mapping table
karllessard Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Build by default on JDK11
  • Loading branch information
@karllessard
karllessard committed Feb 25, 2022
commit 05648697bc63679ba538a0c5d6c9858871fde646
1 change: 1 addition & 0 deletions tensorflow-core/tensorflow-core-api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@
<goal>compile</goal>
</goals>
<configuration>
<release>8</release> <!-- This prevent the plugin to automatically include module-info.java (excluding it won't work) -->
<includes>
<include>org/tensorflow/internal/c_api/presets/*.java</include>
</includes>
Expand Down
1 change: 1 addition & 0 deletions tensorflow-core/tensorflow-core-api/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
requires transitive org.tensorflow.ndarray;
requires org.bytedeco.javacpp;
requires com.google.protobuf;
requires java.logging;

exports org.tensorflow;
exports org.tensorflow.exceptions;
Expand Down
7 changes: 5 additions & 2 deletions tensorflow-core/tensorflow-core-generator/src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,13 @@
=======================================================================
*/
module org.tensorflow.generator {
requires org.commonmark;
requires com.squareup.javapoet;
requires java.compiler;

requires com.github.javaparser.core;
requires com.google.protobuf;
requires com.google.common;
requires com.squareup.javapoet;
requires org.commonmark;

exports org.tensorflow.processor.operator;
exports org.tensorflow.op.generator;
Expand Down