Skip to content

Adds a closeable session result #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karllessard merged 9 commits into from
Feb 8, 2022
Merged

Adds a closeable session result #411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
155fdd6
Adding an autocloseable result class for the output of Session.Runner…
Craigacp Jan 30, 2022
1450980
Fix framework tests.
Craigacp Jan 30, 2022
1035b1d
Making Session.Result final.
Craigacp Jan 30, 2022
5e92bc1
Rearranging the members in Session.Result.
Craigacp Jan 30, 2022
5f89ee1
Fix the tests.
Craigacp Jan 30, 2022
b122dd0
Change the signature of TensorFunction.call to return Result. Migrate…
Craigacp Feb 5, 2022
ad9172c
Missed a bit in the refactor.
Craigacp Feb 5, 2022
022d103
Fixes for review comments, and to ensure that tensors are named as ex…
Craigacp Feb 7, 2022
48ea545
Applying spotless.
Craigacp Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Missed a bit in the refactor.
  • Loading branch information
@Craigacp
Craigacp committed Feb 5, 2022
commit ad9172c68b556b3aad206cde72cd12caf6c2fdc5
2 changes: 1 addition & 1 deletion tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/SavedModelBundle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ public List<SessionFunction> functions() {
* @return list of output tensors, mapped by the signature name
* @throws IllegalArgumentException if no function can be selected by default
*/
public Map<String, Tensor> call(Map<String, Tensor> arguments) {
public Result call(Map<String, Tensor> arguments) {
SessionFunction function = null;
if (functions.size() == 1) {
function = functions.values().iterator().next();
Expand Down
2 changes: 1 addition & 1 deletion tensorflow-core/tensorflow-core-api/src/test/java/org/tensorflow/SavedModelBundleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ public void exportFunctionWithVariables() throws IOException {
// Now call the same function directly from the model
try (TFloat32 zTensor =
(TFloat32)
savedModel.call(Collections.singletonMap("input", xTensor)).get("reducedSum")) {
savedModel.call(Collections.singletonMap("input", xTensor)).get("reducedSum").get()) {
assertEquals(reducedSum, zTensor.getFloat(), EPSILON);
}
}
Expand Down