Skip to content

Install nexusrpc from GitHub - #966

Merged
dandavison merged 5 commits into
mainfrom
install-nexusrpc-from-github
Jul 14, 2025
Merged

Install nexusrpc from GitHub#966
dandavison merged 5 commits into
mainfrom
install-nexusrpc-from-github

Conversation

@dandavison

@dandavison dandavison commented Jul 14, 2025

Copy link
Copy Markdown
Contributor

Problem

  • We want to develop the nexus SDK and respond to those upstream changes in the temporal SDK
  • But currently the nexus SDK is not pinned in the temporal SDK, so we must not release breaking to nexus SDK, since temporal SDK installations in the wild would pick up an incompatible nexus SDK
  • And yet if we were to pin nexus SDK and release temporal SDK, then we wouldn't be able to release bug fixes to nexus SDK by simply releasing nexus SDK

Solution

  • Pin unreleased temporal SDK to unreleased current main of nexus SDK
  • Also break build-binaries so that we do not accidentally release temporal SDK in this state
  • In order to release Temporal SDK, remove the pin-to-GitHub and remove the deliberate breakage of build-binaries, and reinstate them afterwards when next wanting to update the nexus SDK.

@dandavison
dandavison requested a review from a team as a code owner July 14, 2025 20:42
@dandavison
dandavison force-pushed the install-nexusrpc-from-github branch from 3b30268 to eafaa76 Compare July 14, 2025 20:53
@dandavison
dandavison merged commit 808a5f4 into main Jul 14, 2025
16 checks passed
@dandavison
dandavison deleted the install-nexusrpc-from-github branch July 14, 2025 21:12
dandavison added a commit that referenced this pull request Jul 28, 2025
@dandavison
Revert "Install nexusrpc from GitHub (#966)"
c76a5e5 
This reverts commit 808a5f4.
@dandavison dandavison mentioned this pull request Jul 28, 2025
Merged
dandavison added a commit that referenced this pull request Jul 29, 2025
@dandavison
Pin nexusrpc and revert recent nexus updates (#1006)
20bb869 
* Pin nexus

* Revert "Install nexusrpc from GitHub (#966)"

This reverts commit 808a5f4.
tconley1428 pushed a commit that referenced this pull request Aug 28, 2025
@dandavison @tconley1428
Install nexusrpc from GitHub (#966)
96ebdb8 
* Install nexus-rpc from GitHub

* Respond to upstream: {get,set}_operation_definition -> {get,set}_operation

* Respond to upstream: do not use get_operation_factory

* Don't warn on lack of type annotations on op handler

* Nexus typing fixes
tconley1428 pushed a commit that referenced this pull request Aug 28, 2025
@dandavison @tconley1428
Pin nexusrpc and revert recent nexus updates (#1006)
aa3c5ab 
* Pin nexus

* Revert "Install nexusrpc from GitHub (#966)"

This reverts commit 808a5f4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@cretz cretz cretz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dandavison @cretz