Skip to content

Remove direct grpcio dependency - #49

Merged
cretz merged 2 commits into
temporalio:mainfrom
cretz:remove-direct-grpcio
Jun 13, 2022
Merged

Remove direct grpcio dependency#49
cretz merged 2 commits into
temporalio:mainfrom
cretz:remove-direct-grpcio

Conversation

@cretz

@cretz cretz commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

What was changed

Removed the direct grpcio dependency and rely on PyPI version still.

Why?

In issue #46, we tried to mitigate the lack of grpcio mac arm support by referencing a dependency directly. While this is ok during build time, it is not when uploading to PyPI:

Invalid value for requires_dist. Error: Can't have direct dependency: 'grpcio @ https://files.pythonhosted.org/packages/61/dd/d8eda79197a1275e06621850775c7bbf34a141ff92553754dde4e87d7551/grpcio-1.46.3.tar.gz ; sys_platform == "darwin" and platform_machine

So we have removed it. Preliminary tests show this may end up building from source for grpcio when pip gets it as a dependency. This is the best we can do right now.

@cretz
cretz requested a review from a team June 13, 2022 16:00
@cretz
cretz marked this pull request as ready for review June 13, 2022 16:20
@cretz
cretz merged commit 933c373 into temporalio:main Jun 13, 2022
@cretz
cretz deleted the remove-direct-grpcio branch June 13, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants