Remove direct grpcio dependency - #49
Merged
Merged
Conversation
cretz
marked this pull request as ready for review
June 13, 2022 16:20
lorensr
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Removed the direct grpcio dependency and rely on PyPI version still.
Why?
In issue #46, we tried to mitigate the lack of
grpciomac arm support by referencing a dependency directly. While this is ok during build time, it is not when uploading to PyPI:So we have removed it. Preliminary tests show this may end up building from source for
grpciowhenpipgets it as a dependency. This is the best we can do right now.