Flag MD5 as non-security related usage for FIPS compatibility - #472
Merged
Conversation
|
|
cretz
reviewed
Feb 14, 2024
Co-authored-by: Chad Retz <chad.retz@gmail.com>
cretz
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Flagged MD5 as not used for security.
Why?
MD5 algorithm is not allowed under FIPS requirements due to security concerns. Temporal SDK uses MD5 for non-security related reasons, and so it should be flagged as such.
Checklist
We've been monkey-patching this (or using sed on python file directly after installation) up till now.