Skip to content

Upgrade grcpio to 1.53.0 - #359

Merged
cretz merged 2 commits into
temporalio:mainfrom
jackdawm:grpc-1.53.0
Aug 2, 2023
Merged

Upgrade grcpio to 1.53.0#359
cretz merged 2 commits into
temporalio:mainfrom
jackdawm:grpc-1.53.0

Conversation

@jackdawm

@jackdawm jackdawm commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

What was changed

Require minimum version 1.53.0 of grpcio.

Why?

Resolves the high severity CVE-2023-32731, which is applicable as long as grcpio is used.
Also resolves the high severity CVE-2023-1428, however, I do not believe that one applies to our use of grpc.

Checklist

How was this tested:
Ran poe test locally.

@jackdawm
jackdawm requested a review from a team as a code owner August 1, 2023 18:39
Comment thread pyproject.toml

[tool.poetry.dependencies]
grpcio = { version = "^1.48.0", optional = true }
grpcio = {version = "^1.53.0", optional = true}

@cretz cretz Aug 2, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brace format is a little off, but no worries. I can clean that up another time. Thanks!

@cretz

cretz commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Note, grpcio is an opt-in choice for users, we don't really use it (but we gen code that uses it).

@cretz
cretz merged commit 63f63ae into temporalio:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants