Fix macOS x86_64 wheel tag - #287
Merged
Merged
Conversation
cretz
force-pushed
the
fix-mac-wheel
branch
5 times, most recently
from
February 23, 2023 15:55
e0dba06 to
65e91d4
Compare
bergundy
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Wheels used to be properly created with
cp37-abi3-macosx_10_0_x86_64tag but have now changed tocp37-abi3-macosx_12_0_x86_64.We added some fix-wheel code to change this back. However new pip on macOS doesn't support the
10_0tag, only as low as10_4, so we set it to10_9which is something we have seen other projects do.Now all Intel macOS users using Python >= 3.7 and macOS >= 10.9 can work with this wheel.