Skip to content

Add mcp dependency to google-adk extra - #1736

Merged
DABH merged 1 commit into
mainfrom
google-adk-extra-mcp
Aug 10, 2026
Merged

Add mcp dependency to google-adk extra#1736
DABH merged 1 commit into
mainfrom
google-adk-extra-mcp

Conversation

@DABH

@DABH DABH commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What was changed

Added mcp>=1.24,<2 to the google-adk extra (plus uv.lock and a CHANGELOG entry under Fixed).

Why

A fresh pip install temporalio[google-adk] could not import the contrib package:

File ".../google_adk_agents/_mcp.py", line 13, in <module>
    from google.adk.tools.mcp_tool import McpToolset
ImportError: cannot import name 'McpToolset' from 'google.adk.tools.mcp_tool'

google-adk only exports McpToolset when the optional mcp package is importable and keeps mcp behind its own extra, which ours didn't pull in. The constraint matches google-adk's own mcp extra across our supported range (2.2.0–current), following the precedent of our openai-agents extra.

How was this tested

Fresh-venv before/after with only the google-adk extra: reproduces the ImportError on main's metadata, imports cleanly with this change. uv lock --check, poe lint, and pytest tests/contrib/google_adk_agents (39 passed, 5 skipped) all pass.

@DABH
DABH requested a review from a team as a code owner August 10, 2026 18:56
@DABH
DABH enabled auto-merge (squash) August 10, 2026 19:28
@DABH
DABH merged commit 8d8f346 into main Aug 10, 2026
42 of 45 checks passed
@DABH
DABH deleted the google-adk-extra-mcp branch August 10, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants