Add mcp dependency to google-adk extra - #1736
Merged
Merged
Conversation
brianstrauch
approved these changes
Aug 10, 2026
tconley1428
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added
mcp>=1.24,<2to thegoogle-adkextra (plusuv.lockand a CHANGELOG entry under Fixed).Why
A fresh
pip install temporalio[google-adk]could not import the contrib package:google-adkonly exportsMcpToolsetwhen the optionalmcppackage is importable and keepsmcpbehind its own extra, which ours didn't pull in. The constraint matches google-adk's ownmcpextra across our supported range (2.2.0–current), following the precedent of ouropenai-agentsextra.How was this tested
Fresh-venv before/after with only the
google-adkextra: reproduces theImportErroron main's metadata, imports cleanly with this change.uv lock --check,poe lint, andpytest tests/contrib/google_adk_agents(39 passed, 5 skipped) all pass.