Preload type hints and remove global lookup cache - #168
Merged
Conversation
bergundy
approved these changes
Oct 28, 2022
…hinting # Conflicts: # temporalio/workflow.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
No big changes. Moved code around so that argument and return type hints are on the workflow, signal, query, and activity definitions instead of obtained as needed with a global cache.
Why?
Global cache not only was unnecessary since most of these are preloaded into definitions anyways, but #159 showed we don't have a good cache key for functions anyways
Checklist