replaces thrift collector with otlp collector#73
Merged
cretz merged 2 commits intoJun 9, 2023
Merged
Conversation
|
|
bc4976d to
3220c34
Compare
cretz
approved these changes
Jun 9, 2023
Contributor
cretz
left a comment
There was a problem hiding this comment.
Great! Glad to see this works with OTel now. Will approve for CI. Click CLA link and agree to that thing when you can and I'll merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
thrift jaeger spans exporter was replaced by OTLP exporter in opentelemetry example.
Why?
OTLP exporter is more generic as it uses open protocol supported by mutlipe providers.
Checklist
Closes [Feature Request] Replace thrift jaeger exporter with otlp #72
How was this tested:
I've run manually the example of how to use opentelemetry from README.
Any docs updates needed?
Yes. README for opentelemetry example is updated.