Merged
Conversation
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
antmendoza
approved these changes
Dec 31, 2024
Comment on lines
+74
to
+88
| Workflow.newTimer( | ||
| Duration.ofSeconds(TIME_SECS), | ||
| TimerOptions.newBuilder().setSummary("Workflow Timer").build()) | ||
| // We can use thenApply here to cancel our cancelation scope when this timer | ||
| // fires. Note we cannot complete the execution from here, see | ||
| // https://github.com/temporalio/sdk-java/issues/87 | ||
| .thenApply( | ||
| ignore -> { | ||
| // Cancel the workflow cancellation scope allowing us to react to this | ||
| // timer firing | ||
| if (workflowCancellationScope != null) { | ||
| workflowCancellationScope.cancel("Workflow timer fired"); | ||
| } | ||
| return null; | ||
| }); |
Member
There was a problem hiding this comment.
I wonder if having this block inside workflowCancellationScope would produce the same output, so we might not need two cencellationScopes
Contributor
Author
There was a problem hiding this comment.
i think you could. having separate maybe cleaner as then we dont cancel scope within itself. wdyt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sample that shows use of workflow timer instead of using workflow run/exec timeouts