Repository navigation
Fix unread badge counting from inactive accounts when notifyFromAll is disabled. Fix #26938 - #30289
Closed
trollkotze wants to merge 1 commit into
Closed
trollkotze wants to merge 1 commit into
trollkotze wants to merge 1 commit into
Conversation
…ce, no prefix convention visible in their history) and includes the issue-closing keyword as required.
|
|
Collaborator
You could notice it's told there that this is intended behavior... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ce, no prefix convention visible in their history) and includes the issue-closing keyword as required.Fixes #26938
Domain::updateUnreadBadge() unconditionally summed unread counts from all accounts. When notifyFromAll is disabled, it now skips inactive accounts, so the badge only reflects the active account's unreads.
Also triggers a badge recalculation when switching accounts (since the set of counted accounts changes), and when toggling the setting itself.
Changes
Note on Receiving notifications from another account despite the setting being disabled #26938
The issue was closed as intended behavior (Receiving notifications from another account despite the setting being disabled #26938 (comment)), with the reasoning that the "Notify from all accounts" setting was only meant to control desktop notifications, not badge counters.
I've read that and I'm ignoring it, because I think that tthis intention was stupid. A setting called "Notify from all accounts" that still counts unreads from all accounts in the badge is unintuitive — the badge is a notification. If this was intentional, the intention lacked common sense. Over two years have passed since that decision, and intentions can change. I'm opening this PR in the hope the maintainers will reconsider.