Repository navigation
Add Pytest QA suite for all endpoints + known-gap regressions - #1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
test_python_fastapi.py— a self-contained Pytest suite (40 tests) covering all 12 API endpoints (happy path, negative path, auth-required, wrong-credentials) plus targeted regression tests for the Critical/High QA gaps found earlier. No application code is changed — this PR only adds tests.Result:
34 passed, 1 skipped, 5 xfailed(suite is green).Known bugs are asserted at their correct expected behaviour and marked
xfailso the suite stays green while documenting each defect. If a bug is later fixed, the test XPASSes (strict), signalling the marker should be removed. Gaps that need an infra change to test areskipplaceholders.Gap-specific tests:
bobcannot modify/deletealice's post (these pass — ownership is checked).bobreadingalice's post viaGET /{id}and seeing it inGET /arexfail(no ownership check → confidentiality bug).PUT /api/posts/{missing}should return 404; currently returns 200 (xfail strict).GET /api/posts/not-a-uuidshould return 400; currently 500 (xfail strict).xfail(schema has nomin_length).skipplaceholder asserting a future429; needs a limiter (slowapi/Redis) to test.Test harness notes:
Run:
Link to Devin session: https://app.devin.ai/sessions/00a96a01db324b9583129cd1fd0e9ac4
Requested by: @tejasri757