Repository navigation
webchat: patch transitive node-fetch vulnerability (GHSA-r683-j2x4-v87g) - #4455
Merged
Merged
Conversation
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix node-fetch vulnerability in webchat package
webchat: patch transitive node-fetch vulnerability (GHSA-r683-j2x4-v87g)
Jun 4, 2026
stephenhand
approved these changes
Jun 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Dependabot security alert in the legacy webchat/ project by ensuring the vulnerable transitive node-fetch@1.7.3 resolution is replaced with a patched node-fetch version, while keeping the dependency change tightly scoped.
Changes:
- Added an npm
overridesrule inwebchat/package.jsonto force theisomorphic-fetch -> node-fetchresolution to2.6.7. - Regenerated
webchat/package-lock.jsonso the installednode-fetchresolves to2.6.7(and nonode-fetch@1.7.3remains in the lockfile).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| webchat/package.json | Adds an overrides entry to pin the vulnerable transitive dependency path to node-fetch@2.6.7. |
| webchat/package-lock.json | Updates the resolved dependency graph to remove node-fetch@1.7.3 and lock node-fetch to patched versions. |
Files not reviewed (1)
- webchat/package-lock.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependabot flagged
node-fetch@1.7.3inwebchat/package-lock.jsonfor forwarding sensitive headers across untrusted redirects (GHSA-r683-j2x4-v87g / CVE-2022-0235). This PR pins the affected transitive path to the lowest patched version (2.6.7) with a minimal, scoped dependency change.Dependency remediation
overridesentry inwebchat/package.jsonto forceisomorphic-fetch -> node-fetch@2.6.7.webchat/package-lock.jsonvia npm tooling to remove the vulnerable resolution.Reachability assessment
isomorphic-fetchviafbjs) and not directly imported in webchat source.fetchcallsites (e.g. IP lookup, operating hours, end chat, recaptcha) and does not set advisory-listed sensitive headers (authorization,cookie, etc.) in these paths.Checklist
Other Related Issues
None
Verification steps
/webchat, run:npm installnpm ls node-fetchisomorphic-fetch -> node-fetch@2.6.7node-fetch@1.7.3in the dependency treewebchat/package-lock.jsonresolvesnode_modules/node-fetchto2.6.7.AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
Original prompt