Skip to content

fix: Custom reader should read till endblock #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svaningelgem wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: Custom reader should read till endblock #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
14aa441
Adding test data
svaningelgem Jun 9, 2025
67c629f
Changed code
svaningelgem Jun 9, 2025
eebea7e
Fixed the issue.
svaningelgem Jun 9, 2025
1bf2a23
Only an issue under v1, not v2
svaningelgem Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Only an issue under v1, not v2
  • Loading branch information
@svaningelgem
svaningelgem committed Jun 9, 2025
commit 1bf2a236d93142965cf9aafb4eb554f8bcca8e8b
11 changes: 11 additions & 0 deletions tests/test_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,17 @@ def test_qistoph_pr_27(self):
for key, value in pobj.items():
self.assertEqual(parent_map[key], value)

def test_read_custom(self):
"""
Tests to verify that the super-class is properly read when a custom writer is involved.
"""
ser = self.read_file("issue60_custom_reader_endblock.ser")
pobj = javaobj.loads(ser)
self.assertIsNone(pobj.superItems)
self.assertIsNone(pobj.items)
self.assertEquals(pobj.name, "test")
self.assertEquals(pobj.port, 443)


# ------------------------------------------------------------------------------

Expand Down
11 changes: 0 additions & 11 deletions tests/test_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,17 +644,6 @@ def test_writeObject(self):
self.assertEqual(expected["custom_obj"]["field_data"], child_data)
self.assertEqual(expected["custom_obj"]["annotations"], super_data)

def test_read_custom(self):
"""
Tests to verify that the super-class is properly read when a custom writer is involved.
"""
ser = self.read_file("issue60_custom_reader_endblock.ser")
pobj = javaobj.loads(ser)
self.assertIsNone(pobj.superItems)
self.assertIsNone(pobj.items)
self.assertEquals(pobj.name, "test")
self.assertEquals(pobj.port, 443)

# ------------------------------------------------------------------------------


Expand Down