Repository navigation
Conversation
Collaborator
|
Hey, thank you for you PR Could you pls take out all fixes (use lower(name) like, ...) into a separate PR so that we can merge it irrespective of the args/kwargs search? I’m not sure about adding a GIN index on the kwargs field, because in some cases it can bloat the table due to the column’s JSON type |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a second search field on the tasks page to look for text inside a
task's args and kwargs. It works alongside the existing name search.
API / backend:
argsSearchquery param on GET /api/tasks (zod schema, QueryParams type)TasksRepository.getAllacceptsargsand filters by substring overargs || ' ' || kwargs:idx_taskiq_admin_tasks__args_trgm(needs pg_trgm, warns if missing)%and_are matched literallyName search fixes:
lower(name) LIKE, so the existing gin_trgm index is usedthe FTS5 trigram tokenizer cannot match them
UI (tasks/index.vue):
(before, an empty search could not be cleared)