Repository navigation
fix(scheduler): discover schedules of shared tasks in LabelScheduleSource - #698
Open
sinnercode228 wants to merge 1 commit into
Open
sinnercode228 wants to merge 1 commit into
sinnercode228 wants to merge 1 commit into
Conversation
…urce Tasks created with AsyncSharedBroker are bound to the shared broker, so LabelScheduleSource treated every one of them as a foreign task: it logged a "Broker for ... doesn't match scheduler's broker" warning and skipped the task, even when the shared broker's default broker was the scheduler's broker. As a result shared tasks with a `schedule` label were never scheduled, and shared tasks without schedules (e.g. the ones registered by taskiq-pipelines) only produced noise in the scheduler log. Resolve the effective broker of a task the same way SharedDecoratedTask.kicker() does, and warn only when a skipped task actually has schedules that are going to be ignored. Closes: taskiq-python#455 Closes: taskiq-python#526
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…urce
Tasks created with AsyncSharedBroker are bound to the shared broker, so LabelScheduleSource treated every one of them as a foreign task: it logged a "Broker for ... doesn't match scheduler's broker" warning and skipped the task, even when the shared broker's default broker was the scheduler's broker. As a result shared tasks with a
schedulelabel were never scheduled, and shared tasks without schedules (e.g. the ones registered by taskiq-pipelines) only produced noise in the scheduler log.Resolve the effective broker of a task the same way SharedDecoratedTask.kicker() does, and warn only when a skipped task actually has schedules that are going to be ignored.
Closes: #455
Closes: #526