fix warnings on ui server startup#8599
Conversation
| spanProps={{ className: classes.resetButtonSpan }} | ||
| tooltipProps={{ title: 'Reset Form & File' }} | ||
| variant="round" | ||
| variant="circular" |
There was a problem hiding this comment.
Before/After on /quickstart
I'm actually surprised you're not getting warnings about this because:
This also changes the component because of
There was a problem hiding this comment.
> rg variant=\"circul | wc -l
1
> rg variant=\"round | wc -l
29
This is also inconsistent with the rest of the codebase which uses round everywhere.
There was a problem hiding this comment.
OK, the warning was coming from:
https://github.com/mui/material-ui/blob/a9715056ab92595f3e62b045837edbeddc359579/packages/material-ui/src/Fab/Fab.js#L221-L229
we have this wrapper:
taskcluster/ui/src/components/Button/index.jsx
Lines 87 to 88 in e15efa7
so when i updated to use the newer term, we ended up with the default MuiButton. 🙄
I've fixed the wrapper now to respect the new term, and visually checked the UI that it now renders properly, and can confirm the warning has disappeared. Thanks for the review!
988cac3 to
63913ef
Compare
lotas
left a comment
There was a problem hiding this comment.
LGTM also tested locally, didn't notice any major issues
cc55f5f to
61f9a72
Compare
Reduces some of the noise on ui server startup.