This repository was archived by the owner on Nov 12, 2019. It is now read-only.
Conversation
There's a couple changes we need because of our Heroku environment. One of them is to go back to using Node 8.11.4. While we wish to use Node 10 here, in advance of iid-verify, there's a bug somewhere which breaks the Postgres library. The main reason for Node 10 was for a stable N-Api, but it turns out that Node 8.12 will bump N-Api to stable status per: nodejs/node#21593
imbstack
previously approved these changes
Sep 13, 2018
Contributor
Author
|
According to my email, Brian approved the change, but I think the repo rules caused it to be dismissed because of the inconsequential new commit (2db546f), which turned an approved to a "commented". @imbstack I assume removing the travis build icon which will never change is not a problem for you, so I'm going to save the time of a review cycle... let me know if you'd rather I revert it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple small fixes as well as Heroku based CI