Skip to content

Fix usage of env var in action file#1158

Merged
bcantoni merged 2 commits into
masterfrom
fix-publish-pypi
Dec 22, 2022
Merged

Fix usage of env var in action file#1158
bcantoni merged 2 commits into
masterfrom
fix-publish-pypi

Conversation

@bcantoni

Copy link
Copy Markdown
Contributor

No description provided.

@bcantoni

Copy link
Copy Markdown
Contributor Author

Attempting to fix problem with the push to pypi action:

Invalid workflow file: .github/workflows/publish-pypi.yml#L37
The workflow is not valid. .github/workflows/publish-pypi.yml (Line: 37, Col: 13): Unexpected symbol: '$GITHUB_REF'. Located at position 1 within expression: $GITHUB_REF == 'refs/heads/master'

These started failing sometimes, possibly due to a new version of mypy. For now, adding this
switch to keep the old behavior.

https://github.com/hauntsaninja/no_implicit_optional
@jacalata jacalata self-requested a review December 22, 2022 19:31
@bcantoni bcantoni merged commit fb3cd65 into master Dec 22, 2022
@bcantoni bcantoni deleted the fix-publish-pypi branch December 22, 2022 19:49
@bcantoni bcantoni restored the fix-publish-pypi branch December 22, 2022 19:58
vchavatapalli pushed a commit to vchavatapalli/server-client-python that referenced this pull request May 5, 2026
* Fix usage of env var in publishing action file
* Support old implicit optional behavior for mypy (https://github.com/hauntsaninja/no_implicit_optional)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants