Add version awareness to site create/update methods#1068
Merged
Conversation
Breaking change in 3.10: flowsEnabled removed, flowsEditingEnabled and flowsSchedulingEnabled added Added a sample for using the sites calls
create a parent error class to make it easier to catch all tsc errors
|
|
||
|
|
||
| class MissingRequiredFieldError(Exception): | ||
| class MissingRequiredFieldError(TableauError): |
Contributor
There was a problem hiding this comment.
What's the purpose of this class (and the ones below) ?
Contributor
Author
There was a problem hiding this comment.
To be able to return more informative errors
mmuttreja-tableau
approved these changes
Aug 5, 2022
jacalata
added a commit
that referenced
this pull request
Sep 20, 2022
* Update sites requests for Breaking change in 3.10: flowsEnabled removed, flowsEditingEnabled and flowsSchedulingEnabled added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a sample handling sites, fixed sites operations so they work against different API versions.