Jac/amar kumar yadav 1044#1053
Merged
Merged
Conversation
|
Hi @jacalata , i see that you have removed "e" from Lens = "lense" in permission_item.py line 51. Wouldn't it fail because when you do the API call for populating the permissions you add "s" after every item for eg. workbook's', flow's'. And for Lens it would add upto Lens's' but the actual API call has Lens'es'. This is why i kept Lens = "lense" in permission_item.py line 51 rather than Lens = "Lens". Please let me know if my understanding is incorrect. |
Contributor
Author
|
I missed that, you are correct. I've added sample code to validate the methods and updated that logic in a new pull request, since I accidentally merged this one to master anyway #1054 |
jacalata
added a commit
that referenced
this pull request
Jun 4, 2022
|
when can we expect the update in the master branch? @jacalata |
vchavatapalli
pushed a commit
to vchavatapalli/server-client-python
that referenced
this pull request
May 5, 2026
* added new permission populate methods Authored-by: Amar Yadav <AmarKumar.Yadav@genmills.com>
vchavatapalli
pushed a commit
to vchavatapalli/server-client-python
that referenced
this pull request
May 5, 2026
This reverts commit 9fb183d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not sure why the black/mypy jobs were failing for PR #1044 so pushing a new one in my name to check if that fixes it 🤷