stcrashreceiver: fix source loader path detection#10729
Open
mattn wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yasuhiro Matsumoto <mattn.jp@gmail.com>
c00f4da to
b8316bb
Compare
calmh
reviewed
Jun 4, 2026
Comment on lines
+69
to
+70
| knownPrefixes := []string{"/lib/", "/cmd/", "/internal/"} | ||
| idx := -1 |
Member
There was a problem hiding this comment.
internal addition is good, -1 assignment unnecessary and obfuscates what happens later, imho :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash receiver's source loader only recognized
/lib/and/cmd/, so/internal/frames (e.g.internal/db/sqlite/...) were never fetched. This adds/internal/, and fixes the "no prefix matched" guard by initializing the index to-1instead of0, so unrelated paths are skipped instead of treated as a match at offset 0. Adds tests for both cases.