Skip to content
This repository was archived by the owner on Oct 20, 2024. It is now read-only.

feat: Single screen CLI#421

Merged
manuel3108 merged 10 commits intomainfrom
feat/flat-lib-selection
Jun 21, 2024
Merged

feat: Single screen CLI#421
manuel3108 merged 10 commits intomainfrom
feat/flat-lib-selection

Conversation

@AdrianGonz97
Copy link
Copy Markdown
Collaborator

closes #410

This PR also adds clack-core and clack-prompts (which implements inactive group headers) to the repo as a temporary solution until bombshell-dev/clack#199 is (hopefully!) merged.

Here's what the main CLI looks like now:
img
Now that the selection is flat, we should also probably categorize them a bit differently and more specific as well, such as: CSS, DB, Markdown, etc.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: c5f35c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@svelte-add/core Minor
svelte-add Patch
@svelte-add/testing-library Patch
@svelte-add/website Patch
@svelte-add/bootstrap Patch
@svelte-add/bulma Patch
@svelte-add/drizzle Patch
@svelte-add/mdsvex Patch
@svelte-add/routify Patch
@svelte-add/storybook Patch
@svelte-add/tailwindcss Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jun 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: c5f35c2

@svelte-add/clack-core

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/clack-core@421

@svelte-add/clack-prompts

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/clack-prompts@421

@svelte-add/bootstrap

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/bootstrap@421

@svelte-add/bulma

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/bulma@421

@svelte-add/drizzle

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/drizzle@421

@svelte-add/mdsvex

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/mdsvex@421

@svelte-add/tailwindcss

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/tailwindcss@421

@svelte-add/core

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/core@421

svelte-add

npm i https://pkg.pr.new/svelte-add/svelte-add@421

@svelte-add/routify

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/routify@421

@svelte-add/storybook

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/storybook@421

@svelte-add/testing-library

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/testing-library@421

@svelte-add/website

npm i https://pkg.pr.new/svelte-add/svelte-add/@svelte-add/website@421


templates

@AdrianGonz97
Copy link
Copy Markdown
Collaborator Author

AdrianGonz97 commented Jun 20, 2024

hmm, it looks like the docker images are failing to be pulled, causing the tests to fail. I wonder if there's a service outage?

@benmccann
Copy link
Copy Markdown
Collaborator

Yeah, making the categories something like CSS, DB, Markdown, UI development was the first thing that jumped out at me. I don't know if having a bunch of single-itemed categories will feel weird? The other way we might be able to handle that would be to collapse it if there's a single item like:

│  ◻ Database: Drizzle

Instead of:

│ Database
│  ◻ Drizzle

It's hard to know though without seeing it

This is awesome!!

Comment thread packages/clack-prompts/package.json
@AdrianGonz97
Copy link
Copy Markdown
Collaborator Author

AdrianGonz97 commented Jun 20, 2024

I don't know if having a bunch of single-itemed categories will feel weird? The other way we might be able to handle that would be to collapse it if there's a single item like:

│  ◻ Database: Drizzle

Instead of:

│ Database
│  ◻ Drizzle

I think mixing and matching groups in that way might be more confusing 😅 , especially when it would line up along with whichever group is above it:

┌  Welcome to Svelte Add!
│
◆  What would you like to add to your project?
│   CSS
│  │ ◻ Bootstrap (Build fast, responsive sites with Bootstrap)
│  │ ◻ Bulma
│  │ ◻ TailwindCSS
│  └ ◻ Database: Drizzle
│   Markdown
│  └ ◻ mdsvex
│   Tools
│  └ ◻ Storybook
└

to make it not part of any group would require more customizing of @svelte-add/clack-prompts (and maybe clack-core), which might turn it into a permanent package for us since i don't really see a custom feature like that being added to clack

It's hard to know though without seeing it

here's a preview with single item groups:
img
I don't think it's too bad

@benmccann
Copy link
Copy Markdown
Collaborator

I think it'd probably look more like:

┌  Welcome to Svelte Add!
│
◆  What would you like to add to your project?
│   CSS
│  │ ◻ Bootstrap (Build fast, responsive sites with Bootstrap)
│  │ ◻ Bulma
│  └ ◻ TailwindCSS
│   Database: Drizzle
│   Markdown: mdsvex
│   UI development: Storybook
└

But yeah, actually seeing that written out in full I don't like it as much

And I think the version with the single groups in your preview looks quite good actually! Plus, I imagine we'll end up with more multi-item groups over time

Copy link
Copy Markdown
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the changes.

Additionally I don't mind the single grouped options as well. That's a massive improvement to the current situation

Comment thread packages/clack-prompts/package.json
Copy link
Copy Markdown
Member

@manuel3108 manuel3108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes things are just to obvious to see them yourself. Using changeset publish seem pretty smart. Let's give it a try!

@manuel3108 manuel3108 merged commit c345f26 into main Jun 21, 2024
@manuel3108 manuel3108 deleted the feat/flat-lib-selection branch June 21, 2024 17:13
@github-actions github-actions Bot mentioned this pull request Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single screen CLI

3 participants