fix: CWE-434 in src/main/java/org/cysecurity/cspf/jvl/controller/AddPage.java - #35
Open
sudhakarkr wants to merge 1 commit into
Open
fix: CWE-434 in src/main/java/org/cysecurity/cspf/jvl/controller/AddPage.java#35sudhakarkr wants to merge 1 commit into
sudhakarkr wants to merge 1 commit into
Conversation
…age.java Restricts the user-supplied filename with a strict allowlist regex (alphanumerics, underscore, dash; max 64 chars; extension limited to .txt/.html/.htm) so executable server-side extensions like .jsp cannot be uploaded, blocking the web-shell vector. Additionally canonicalizes the resolved path and verifies its parent equals the intended pages directory, preventing path traversal via encoded separators or crafted names. On any validation failure the servlet fails closed by printing an error and returning early, without opening or creating any file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated code fix — CWE-434
File:
src/main/java/org/cysecurity/cspf/jvl/controller/AddPage.javaSeverity: critical
Lane: code-fix
Skill used:
default-secure-codingAssessment
Rationale
Restricts the user-supplied filename with a strict allowlist regex (alphanumerics, underscore, dash; max 64 chars; extension limited to .txt/.html/.htm) so executable server-side extensions like .jsp cannot be uploaded, blocking the web-shell vector. Additionally canonicalizes the resolved path and verifies its parent equals the intended pages directory, preventing path traversal via encoded separators or crafted names. On any validation failure the servlet fails closed by printing an error and returning early, without opening or creating any file.
Validation
Opened by the vulnerability management platform after human approval.