Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Remove dead axisymmetric Jacobian terms from the SST source
Proposed Changes
In
CSourcePieceWise_TurbSST::ComputeResidual,ResidualAxisymmetricConvectionDiffusionsubtractsyinv * Volume * rhovfrom the diagonal ofJacobian_i, but the "Implicit part" right after it assignsJacobian_i[i][j] = ..., so those contributions were always discarded. This PR removes the dead linesand adds a comment explaining why the term is intentionally left out of the Jacobian.
I first tried keeping the terms (calling the axisymmetric function after the implicit block), but:
be
yinv * Volume * v, notyinv * Volume * rho * v.Results on
axisymmetric_rans/air_nozzle/air_nozzle_restart.cfg(serial, until rms[Rho] = -12):rho * v, both signs)max(v, 0))So the current behaviour is the right one, and this PR only makes it explicit. Results are bit-identical
(the removed lines never had an effect), so no regression values change. I checked
axi_rans_air_nozzle_restart(serial and 2 ranks) andaxi_rans_air_nozzle_specieslocally.Related Work
#2948 edits the same implicit block of the SST source; this PR does not touch those lines.
PR Checklist
pre-commit run --allto format old commits.