Add Stylesheet class that proxies methods to two stylesheets - #440
Conversation
Adding a separate global stylesheet broke server side rendering, because stylesheet.rules only returned component styles. We now have a single stylesheet class, that inserts into the specified sheet, and proxies all other methods to both sheets.
Generated by 🚫 dangerJS |
|
Nice one! Should we ship this in |
|
Shipping this in v2 will require a few changes to how we do this, since the stylesheet module is quite a bit different in |
|
I can make a separate pr into |
I fear that this'll mess us up when we merge master into v2. Any ideas how we could avoid that? |
|
My PR into v2 can be two things:
|
|
Sounds good! |
|
Need to fix CI to land this though 😉 |
|
oops, on it. |
mxstbr
left a comment
There was a problem hiding this comment.
LGTM, thanks so much! Will publish as v1.4.2, looking forward to the PR against v2
|
Cool, I'll make the v2 PR as soon as this is merged. |
|
Amazing, @xcoderzach Thanks |
|
Sorry, totally forgot to merge this. Will ship now! |
|
Ping @xcoderzach, don't want to forget about this PR. Any news? |
Adding a separate global stylesheet broke server side rendering,
because stylesheet.rules only returned component styles. We now
have a single stylesheet class, that inserts into the specified
sheet, and proxies all other methods to both sheets.