Do not pass innerRef to the component - #310
Merged
chiefjester merged 4 commits intoDec 14, 2016
Merged
Conversation
Generated by 🚫 danger |
…dComponent.js and StyledNativeComponent.js
chiefjester
reviewed
Dec 12, 2016
| @@ -84,7 +84,7 @@ export default (ComponentStyle: Function) => { | |||
| const propsForElement = {} | |||
| /* Don't pass through non HTML tags through to HTML elements */ | |||
| Object.keys(this.props) | |||
Member
There was a problem hiding this comment.
What if we use Object.keys(rest), then on this line:
We do this const { className, children, innerRef, ...rest } = this.props
No need for adding innerRef in filter, /cc @mxstbr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid
Warning: Unknown prop `innerRef` on <textarea> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop