Skip to content

switch startsWith to normal regex - #217

Merged
mxstbr merged 3 commits into
styled-components:masterfrom
chiefjester:startsWithFix
Nov 20, 2016
Merged

switch startsWith to normal regex#217
mxstbr merged 3 commits into
styled-components:masterfrom
chiefjester:startsWithFix

Conversation

@chiefjester

Copy link
Copy Markdown
Member

- fixes styled-components#212
- uses regex instead of es2015 startsWith for IE10 compat
- added pr link and issue link
@mxstbr-bot

mxstbr-bot commented Nov 19, 2016

Copy link
Copy Markdown
1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@mxstbr mxstbr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@mxstbr
mxstbr merged commit 0120683 into styled-components:master Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internet explorer 10+ styled-components issue (JS error)

3 participants