Skip to content

fix keyframes with > 1 interpolation - #2013

Merged
quantizor merged 2 commits into
developfrom
debug-keyframes
Sep 17, 2018
Merged

fix keyframes with > 1 interpolation#2013
quantizor merged 2 commits into
developfrom
debug-keyframes

Conversation

@quantizor

Copy link
Copy Markdown
Contributor

No description provided.

@quantizor
quantizor requested review from a team and Fer0x September 17, 2018 19:16
@quantizor quantizor mentioned this pull request Sep 17, 2018
@alansouzati

Copy link
Copy Markdown
Contributor

nice! thanks for adding a test for it 🎉

@quantizor

Copy link
Copy Markdown
Contributor Author

@alansouzati thanks for writing it ;)

@quantizor
quantizor merged commit fdc1190 into develop Sep 17, 2018
@quantizor
quantizor deleted the debug-keyframes branch September 17, 2018 19:21
@alansouzati

Copy link
Copy Markdown
Contributor

that was fast!!! any hopes to get a beta 6 release? 🙏

@Fer0x

Fer0x commented Sep 17, 2018

Copy link
Copy Markdown
Contributor

Looks good, but I noticed strange behavior in this example https://codesandbox.io/s/jv3q8z9o65

Computed styles contains this:

@-webkit-keyframes yJWz{from{opacity:0;}from to{opacity:1;}}
@keyframes yJWz{from{opacity:0;}from to{opacity:1;}}

Need to reproduce it after this merge.

@quantizor

Copy link
Copy Markdown
Contributor Author

@Fer0x there's a closing brace missing in opacityAnimation

beta 6 is out, just cut it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants