Skip to content

Fix timeout in tests on Windows [1.x]#137

Merged
bajtos merged 1 commit into
1.xfrom
fix/ci-windows-1x
Nov 14, 2016
Merged

Fix timeout in tests on Windows [1.x]#137
bajtos merged 1 commit into
1.xfrom
fix/ci-windows-1x

Conversation

@bajtos
Copy link
Copy Markdown
Member

@bajtos bajtos commented Nov 14, 2016

Rework the test waiting for connection failure to periodically check whether the error has been reported yet, instead of having a constant timeout value.

See also #135 that fixed the CI on master.

cc @superkhau

Rework the test waiting for connection failure to periodically check
whether the error has been reported yet, instead of having a constant
timeout value.
@bajtos bajtos self-assigned this Nov 14, 2016
@bajtos bajtos added the #review label Nov 14, 2016
@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Nov 14, 2016

The Node v0.10 failure is unrelated:


D:\t\t1097085489204056866dirbfr\node_modules\build-framework\node_modules\mocha-jenkins-reporter\lib\jenkins.js:259
    var n = ++currentSuite.failures;
                          ^
TypeError: Cannot read property 'failures' of null
    at Runner.<anonymous> (D:\t\t1097085489204056866dirbfr\node_modules\build-framework\node_modules\mocha-jenkins-reporter\lib\jenkins.js:259:27)
    at Runner.emit (events.js:117:20)
    at Runner.fail (D:\workspace\loopback-component-push\b88abec9\node_modules\mocha\lib\runner.js:233:8)

I think we should start removing Node v0.10 from our CI builds, what do you think @rmg and @superkhau?

@bajtos bajtos merged commit b02a30f into 1.x Nov 14, 2016
@bajtos bajtos deleted the fix/ci-windows-1x branch November 14, 2016 10:54
@bajtos bajtos removed the #review label Nov 14, 2016
@superkhau
Copy link
Copy Markdown
Contributor

@bajtos Thanks for fixing the windows issues. 👏

WIth regard to removing CI builds, yes we should removing it ASAP. We're just wasting time working on those issues now IMO. You also sent the notification on GG announcement regarding the dropping -- did you hear anything back yet?

@bajtos
Copy link
Copy Markdown
Member Author

bajtos commented Nov 15, 2016

You also sent the notification on GG announcement regarding the dropping -- did you hear anything back yet?

No, see https://groups.google.com/forum/#!topic/loopbackjs/b9MCPOHrUgk The post got only 21 views, looks like there are not many people watching the mailing list.

@superkhau
Copy link
Copy Markdown
Contributor

The GG post wasn't pinned to the top (I pinned it now for you), so that would probably mean less views.

The post got only 21 views, looks like there are not many people watching the mailing list.

We gotta do something about that. ;) I don't blame them though because we haven't really been responding promptly there IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants