Skip to content

Drop Node.js 6 support#95

Merged
dhmlau merged 1 commit into
masterfrom
drop-nodejs6
Feb 12, 2020
Merged

Drop Node.js 6 support#95
dhmlau merged 1 commit into
masterfrom
drop-nodejs6

Conversation

@dhmlau
Copy link
Copy Markdown
Member

@dhmlau dhmlau commented Feb 11, 2020

Description

CI for #94 is failing because of the unexpected token:

/home/travis/build/strongloop/loopback-cli/node_modules/loopback-workspace/node_modules/mkdirp/lib/opts-arg.js:7
    opts = { mode: 0o777 & (~process.umask()), fs, ...opts }
                                                   ^^^
SyntaxError: Unexpected token ...
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)

Since Node.js 6 has reached EOL, we're dropping the Node.js 6 support.
I didn't make it to be Node.js 10+ because APIC might need Node.js 8 as well.

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@dhmlau
Copy link
Copy Markdown
Member Author

dhmlau commented Feb 12, 2020

@slnode test please

@dhmlau dhmlau merged commit fd76267 into master Feb 12, 2020
@delete-merged-branch delete-merged-branch Bot deleted the drop-nodejs6 branch February 12, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants