Deps: remove SQLite#564
Merged
Merged
Conversation
51f47ad to
9186b6d
Compare
This blocks upgrading to ActiveRecord 6.x, as the query for `true`/`false` values is different for some reason depending on the database, and it fails tests with SQLite. The simplest solution in this case is probably to remove SQLite. The production setup uses Postgres, so better to have a consistent database setup, anyway. This also frees us up to take advantage of Postgres specific features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This blocks upgrading to ActiveRecord 6.x, as the query for
true/falsevalues is different for some reason depending on thedatabase, and it fails tests with SQLite. The simplest solution in this
case is probably to remove SQLite. The production setup uses Postgres,
so better to have a consistent database setup, anyway. This also frees
us up to take advantage of Postgres specific features.