Specs: add tests for FetchFeeds#547
Merged
Merged
Conversation
This is super janky, grabbing the instance variable out of the instance, but there doesn't seem to be a great way to test for the underlying issue, which is that in some cases jobs don't work when passing the entire record. I thought also about inspecting the job more closely, but wasn't able to think of a great solution there, either. I'd like to refactor this class some down the road to not try to juggle both `@feeds_ids` and `@feeds` variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is super janky, grabbing the instance variable out of the instance,
but there doesn't seem to be a great way to test for the underlying
issue, which is that in some cases jobs don't work when passing the
entire record. I thought also about inspecting the job more closely, but
wasn't able to think of a great solution there, either. I'd like to
refactor this class some down the road to not try to juggle both
@feeds_idsand@feedsvariables.