Adds group_id to Feeds#edit#393
Conversation
|
I myself don't use the groups feature, but this looks like a reasonable addition IMO. |
|
Not sure on this...don't use groups myself either. I think it will be confusing to people using the app to see UI elements for editing groups, but no changes to the rest of the app. |
|
Yes, that's why the group field is only shown if you have any groups defined. People that are not using the groups feature won't see this field. |
|
I do use groups so I think this would definitely be useful. Hiding the drop down for people that don't have any groups defined seems reasonable to me. Perhaps in the future we could add a simple crud interface for groups to make it even more useful. |
|
Yes, but I think a CRUD for groups would only make sense if they're actually used in the web app itself. As long as that is not the case I'd hide it with a config so it won't confuse people that only use the web app. |
2787679 to
baef5d1
Compare
|
I took a stab at the design and ended up with this:
I've also cleaned up the commit a bit. |
|
@jeroenj code looks fine 👍. However I just took your branch for a spin and noticed that the current group of a feed is not correctly set on the edit feed page. Looking at the code you're missing something to mark an |
|
Yes, indeed. I found out too. I did not have the time yet to fix it. |
baef5d1 to
a854041
Compare
|
@pascalw I'v fixed marking the current |
|
LGTM! 👍 |
I've been using groups for quite a while. While this is a hidden feature it would be handy that feeds could be linked using the interface. The dropdown will only be shown when there are any groups so that people not using the feature don't get confused about it.
I might also look into more group management later on, but I rarely use the web interface so it's not really a priority for me right now. (and I've got a lot of other stuff on my plate)
The only think that needs to be fixed is the design of the dropdown. I guess stringer is a custom theme? Would any of you mind to help me fix it? I'll try to fix it myself but it might take a few days/weeks.