Fix RuboCop lint offences#392
Conversation
Both of these occurrences appear perfectly legitimate to me.
|
Those exceptions could be scope to whatever Feedjira can create; but I'm not aware of a great way to get that list. |
|
👍 thanks for tackling that :) |
|
Thanks for the hint! I'll have a look next time I have a chance to work on this. |
|
Let's merge for now with the inline exceptions -- I can live with those :) |
Mostly by prefixing the unused arguments with `_` to indicate they're unused. This is because the unused arguments are often parts of protocols/interfaces. Does remove the unused `parser` parameter from `get_feed_for_url`, though.
This is done by rescuing `StandardError` instead of `Exception`, which should still cover most if not all errors raised by the Curb and Feedjira libraries. We no longer try to rescue fatal errors, like `NoMemoryError`, which is what RuboCop was complaining about. An even better fix for this could be to rescue an even narrower set of errors, but I'll leave that until the next time.
45504b3 to
0ae4144
Compare
|
|
Thanks! |
There's currently one rule left,Lint/RescueException, that needs more thought.Ready for review.