FIX: Add default precision to db#1166
Merged
mockdeep merged 2 commits intoMar 14, 2024
Merged
Conversation
90bed18 to
d86a002
Compare
mockdeep
reviewed
Mar 8, 2024
| t.string "name", limit: 255, null: false | ||
| t.datetime "created_at", precision: nil, null: false | ||
| t.datetime "updated_at", precision: nil, null: false | ||
| create_table "groups", force: :cascade do |t| |
Collaborator
There was a problem hiding this comment.
It looks like this also introduced changes to the primary key. We'll need a migration for that as well to ensure that production instances get updated.
| t.string "username", null: false | ||
| create_table "users", force: :cascade do |t| | ||
| t.string "password_digest" | ||
| t.datetime "created_at" |
Collaborator
There was a problem hiding this comment.
Looks like we lost the null: false from some of these.
| t.string "api_key", limit: 255, null: false | ||
| t.string "username", null: false | ||
| create_table "users", force: :cascade do |t| | ||
| t.string "password_digest" |
Collaborator
There was a problem hiding this comment.
Looks like this changed as well. Probably need a separate migration to remove the limit here.
d86a002 to
c83f8c2
Compare
Generate migration file to set the default precision for datetime columns in the database
c83f8c2 to
fcb22a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate migration file to set the default precision to 6 for datetime columns in the database