fix(bidi): set Strands user agent for Nova Sonic client#2132
Open
jonathan343 wants to merge 1 commit intostrands-agents:mainfrom
Open
fix(bidi): set Strands user agent for Nova Sonic client#2132jonathan343 wants to merge 1 commit intostrands-agents:mainfrom
jonathan343 wants to merge 1 commit intostrands-agents:mainfrom
Conversation
d063f99 to
dc45f1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures the bidirectional Nova Sonic Bedrock client includes the Strands user-agent marker when making requests. That brings Nova Sonic traffic in line with expected SDK attribution and adds a focused unit test covering the client configuration used in
start().Related Issues
None
Documentation PR
None
Type of Change
Bug fix
Testing
Focused unit test added for Nova Sonic client startup configuration. Additionally, I ran the bidirectional example in the README.md and verified the outgoing
User-Agentheader includeslib/strands-agent#<version>:hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.