Skip to content

add check for first available header marker #93 - #94

Merged
jmglsn merged 1 commit into
stomp-php:masterfrom
fin-sn-de:bugfix/93-line-feed-header-marker-overruled-by-carriage-return-line-feed-in-body
Sep 15, 2017
Merged

add check for first available header marker #93#94
jmglsn merged 1 commit into
stomp-php:masterfrom
fin-sn-de:bugfix/93-line-feed-header-marker-overruled-by-carriage-return-line-feed-in-body

Conversation

@jmglsn

@jmglsn jmglsn commented Sep 15, 2017

Copy link
Copy Markdown
Member

Otherwise carriage return + line feed will be used as marker, even if
frame is escaped with line feed only.

Thanks to @mattford (#93)

Otherwise carriage return + line feed will be used as marker, even if
frame is escaped with line feed only.

Thanks to @mattford

@staabm staabm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jmglsn
jmglsn merged commit 4b612f3 into stomp-php:master Sep 15, 2017
@jmglsn

jmglsn commented Sep 15, 2017

Copy link
Copy Markdown
Member Author

@staabm thx for fast feedback!

@jmglsn
jmglsn deleted the bugfix/93-line-feed-header-marker-overruled-by-carriage-return-line-feed-in-body branch September 15, 2017 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants