fix for false exceptions in combination with pcntl_signal - #65
Merged
Conversation
Member
|
Looks good, but should be covered by a test |
Member
Author
|
I'll try to do so - on first approach I thought it should be easy, as it turned out it isn't. |
Member
|
As I got more insights on when this might happen, I guess doing a unit test is not feasible. Found this symfony commit for reference: I am fine to merge this without a test. |
Member
Author
|
Had a hard time with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a long running consumer which makes use of
pcntl_signal. When it comes to new signals while we're instream_selectthis will return false and provoke a connection exception, even if there is no connection problem.